Hi guys,
I have just created a branch of AsciidoctorJ project to start the migration to Java 8 (for using Nashorn and allow users render documents using asciidoctor.js from Java instead of JRuby).
The link is here:
https://github.com/lordofthejars/asciidoctorj/tree/feature_189Let me summarize some changes:
pom.xml now uses 1.8 compile version
Now Asciidoctor is not an interface but a class (
https://github.com/lordofthejars/asciidoctorj/blob/feature_189/src/main/java/org/asciidoctor/Asciidoctor.java). This class implements all operations that users may use independently of render method (JRuby or Nashorn). For example methods like convertDirectory, convertFiles, convertFile and so on fall in this class. This class has an attribute of type AsciidoctorJ (
https://github.com/lordofthejars/asciidoctorj/blob/feature_189/src/main/java/org/asciidoctor/internal/AsciidoctorJ.java) This is an interface which is not intend to be used by final users. It implements basic operations like load, convert, convertFile, or registering extensions. Then the key point is that JRuby implementation implements this interface (
https://github.com/lordofthejars/asciidoctorj/blob/feature_189/src/main/java/org/asciidoctor/internal/RubyAsciidoctorJ.java), Javascript implementation will implement this interface as well, so effectively only implementing 10 methods you will have AsciidoctorJ rendering documents in another system.
One thing that may look strange is this method:
<T extends ExtensionRegistry> T create(final Class<T> type) throws IllegalArgumentException;
If you look current AsciidoctorJ extension mechanism you can get two different objects JavaExtensionRegistry and RubyExtensionRegistry. The first one is used to register extensions written in Java and the second one for extensions written in Ruby. But for example both of them only works if you are using JRuby (some logic is done behind the scene). So what's happen with JavaScript? You will be able to write extensions in Javascript and in Java (but using Nashorn and not JRuby) so we need a generic way to create this classes. This method is generic enough to fit this requirement. (
https://github.com/lordofthejars/asciidoctorj/blob/feature_189/src/main/java/org/asciidoctor/internal/RubyAsciidoctorJ.java#L207)
If you download the code you will see that tests does not compile. Why? Because there are some breaks on method contracts. Before fixing this problems I prefer to start a feedback round so when we definitely have a final contract where everybody feels comfortable then I will fix them.
This issue is only about integration with AsciidoctorJs and the modifications I need to insert into the code. I will open more rounds to talk about other problems we might target to fix like FunctionalInterfaces or Symbols.
Thank you very much for your collaboration. Feel free to clone the project, do PR or comment this post. Meanwhile I will start the first prototype of AsciidoctorJs inside Nashorn.
Alex.
Locked
