Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
17 posts
|
I've found the need to use custom templates so our HTML output via Jekyll is more aligned with HTML5 best practices (along the lines of http://www.github.com/asciidoctor/asciidoctor#242), and I've been working with the html5 templates in http://www.github.com/jirutka/asciidoctor-html5s. These are working fine, and I think we'll like the additional control in the long run.
However, our HTML build uses Jekyll and Ant, and every time I build with these templates, I get 30+ of these errors (one line for every template I've added): Slim::Engine: Option :asciidoc is invalid I think this is related to these sections in our _config.yml: asciidoc: {} asciidoctor: safe: 0 template_dir: _templates (etc.) I found http://www.github.com/asciidoctor/asciidoctor#1347, and am sort of guessing that the error is coming from the fact that the safe mode of the template engine doesn't match the safe mode of the document, and it of course cannot interpret the asciidoc section. I need to get rid of these errors. I tried adding something like this to my _config.yml: asciidoctor: safe: 0 template_dir: _templates template_engine_options: slim: asciidoc: safe: unsafe attributes: (etc.) But it had no effect. I also tried a few variations without the asciidoc line, as part of the later attributes section, etc., but none of them changed anything either. Any ideas? Thanks in advance for suggestions. |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
Administrator
2681 posts
|
Is issue still outstanding, or have you gotten to the bottom of it? I can't remember where we left off. Cheers, -Dan On Tue, Sep 18, 2018 at 3:11 PM ctargett [via Asciidoctor :: Discussion] <[hidden email]> wrote: I've found the need to use custom templates so our HTML output via Jekyll is more aligned with HTML5 best practices (along the lines of http://www.github.com/asciidoctor/asciidoctor#242), and I've been working with the html5 templates in http://www.github.com/jirutka/asciidoctor-html5s. These are working fine, and I think we'll like the additional control in the long run. ... [show rest of quote] -- Dan Allen | @mojavelinux | https://twitter.com/mojavelinux |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
17 posts
|
I haven't had time to go back to this issue to continue trying to figure it out, but it definitely still exists.
|
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
Administrator
2681 posts
|
This seems like it has to do with asciidoctor-html5s. It's the software that is pulling in slim, and perhaps it is setting options that are not compatible with the version of slim that your project is using. I recommend filing an issue in that project. That converter should be completely self-contained, so there shouldn't be any Asciidoctor-specific configure you need to do in the Jekyll config other than load the gem. Cheers, -Dan On Wed, Oct 17, 2018 at 2:37 PM ctargett [via Asciidoctor :: Discussion] <[hidden email]> wrote: I haven't had time to go back to this issue to continue trying to figure it out, but it definitely still exists. -- Dan Allen | @mojavelinux | https://twitter.com/mojavelinux |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
Administrator
2681 posts
|
In reply to this post by ctargett
When you file the issue, I would also recommend sharing a stripped down project that reproduces the problem. If we do find that it's Jekyll AsciiDoc that's causing the problem, we can address it then. Cheers, -Dan On Wed, Oct 17, 2018 at 3:22 PM Dan Allen <[hidden email]> wrote:
... [show rest of quote] -- Dan Allen | @mojavelinux | https://twitter.com/mojavelinux |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
17 posts
|
Ah, good idea, I will try to do that. Thanks for the advice & for following up on the problem. |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
17 posts
|
You know, your idea about an incompatibility with Slim versions made me check what happened with another version, and if I use Slim v3.0 (which asciidoctor-html5 uses), instead of 4.0.1, I don't get those errors at all. That's actual fine for us - it's the "scary" errors I don't want to introduce into our build process output, I don't think we really care which Slim version we use.
I'll still file an issue anyway warning them and other users about the problem. |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
Administrator
2681 posts
|
Thanks for following up. It's great to hear that you found a path forwarad. It appears Slim changed something in the API that we'll have to look into. That's good to know. If you file an issue, we can be sure to track it down. Best Regards, -Dan On Thu, Oct 18, 2018 at 2:50 PM ctargett [via Asciidoctor :: Discussion] <[hidden email]> wrote: You know, your idea about an incompatibility with Slim versions made me check what happened with another version, and if I use Slim v3.0 (which asciidoctor-html5 uses), instead of 4.0.1, I don't get those errors at all. That's actual fine for us - it's the "scary" errors I don't want to introduce into our build process output, I don't think we really care which Slim version we use. -- Dan Allen | @mojavelinux | https://twitter.com/mojavelinux |
Free forum by Nabble | Edit this page |