Asciidoctor :: Discussion

Asciidoctor Maven Plugin: asciidoctor-diagram vs asciidoctorj-diagram

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Jeremie Bresson

Asciidoctor Maven Plugin: asciidoctor-diagram vs asciidoctorj-diagram

The "asciidoctor-diagram-example" example uses asciidoctor-diagram as gems.
See: https://github.com/asciidoctor/asciidoctor-maven-examples/tree/master/asciidoctor-diagram-example

I am wondering if it would be possible to use asciidoctorj-diagram instead.

If yes can you tell how the pom.xml should be changed?

mojavelinux

Re: Asciidoctor Maven Plugin: asciidoctor-diagram vs asciidoctorj-diagram

Administrator

In fact, there is already an open pull request to switch from the Asciidoctor Diagram gem to AsciidoctorJ Diagram. We just need to push it to completion.

https://github.com/asciidoctor/asciidoctor-maven-examples/pull/12

Note that there are some related issues in the issue tracker, while we are changing things in that example. See https://github.com/asciidoctor/asciidoctor-maven-examples/search?q=diagram&state=open&type=Issues&utf8=%E2%9C%93

Cheers,

-Dan

On Sat, Dec 12, 2015 at 12:12 AM, Jeremie Bresson [via Asciidoctor :: Discussion] <[hidden email]> wrote:

The "asciidoctor-diagram-example" example uses asciidoctor-diagram as gems.
See: https://github.com/asciidoctor/asciidoctor-maven-examples/tree/master/asciidoctor-diagram-example

I am wondering if it would be possible to use asciidoctorj-diagram instead.

If yes can you tell how the pom.xml should be changed?

If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/Asciidoctor-Maven-Plugin-asciidoctor-diagram-vs-asciidoctorj-diagram-tp4076.html

To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML

Dan Allen | @mojavelinux | http://google.com/profiles/dan.j.allen

Jeremie Bresson

Re: Asciidoctor Maven Plugin: asciidoctor-diagram vs asciidoctorj-diagram

mojavelinux wrote

In fact, there is already an open pull request to switch from the
Asciidoctor Diagram gem to AsciidoctorJ Diagram. We just need to push it to
completion.

https://github.com/asciidoctor/asciidoctor-maven-examples/pull/12

It is not possible for me to propose a new version of the change directly on asciidoctor-maven-examples/pull/12. (Pull requests are fork & branches based. I am used to the gerrit workflow).
I have opened a new pull request for that: asciidoctor-maven-examples/pull/37

I think this will close all open issues concerning diagram in the asciidoctor-maven-examples.
To definitively close the subject, help is appreciated on the ruby extension from a maven build topic.