Login  Register

Re: About Asciidoctor Maven integration: A custom lifecycle

Posted by rrialq on Aug 14, 2019; 8:36am
URL: https://discuss.asciidoctor.org/About-Asciidoctor-Maven-integration-A-custom-lifecycle-tp7063p7081.html

Hi, mojave.

I chose that name because I didn't know if it would be legal to use asciidoctor as part of the name.
My first choice was asciidoctor-lifecycle-maven-plugin.
I finally decided to change it so as not to disturb the community asciidoctor.

I will rename this to asciidoctor-lifecycle-maven-plugin. Please, wait till I finished before opening issues.

About the functionality.
* I have started to write this plugin to simplify a big parent pom I wrote to manage my needs. I think many of us have the same problems about this and a similar way to solve them.
* A lifecycle is only an xml file, where you define the phase names in sequential order, and if any phase is binded to a mojo.
* The plugin contains a new mojo for downloading themes.

Imagine we merge my project with asciidoctor-maven-plugin (I think it has sense in the future, to minimize configuration; for now I think is a better idea to separate them to allow a fasterevolution of the asciidoctor-maven-plugin).
* What should do somebody that only want the basic functionality? Using the same configuration as nowday, binding the mojos to phases in the default lifecycle (no change from current documentation).
* What should do somebody that want the functionality of the lifecycle? Using the documentation in this plugin.

So both of functionalities can be combined in the same plugin and using one or another as your own needs.




mojavelinux wrote
I was going to suggest a new plugin that offers this more advanced
functionality, so I'm glad to see you went ahead and created it. Like Abel
was saying, we're not closed to it. It's just that we need to retain a
basic plugin for the average use case. But in no way does that rule out
having an advanced lifecycle plugin.

The only thing I'd suggest is to try to be a little less cute with the
name. "mydoctor" really doesn't communicate what it is. Perhaps
asciidoctor-lifecycle-maven-plugin, or something more descriptive would be
better. Just hacking up the name of a project makes it hard to gain
traction because it looks unrelated. And it also dilutes the brand of the
project name. (For example, you don't say "myyota" when you name a Toyota
community site).

Best,

-Dan

On Tue, Aug 13, 2019 at 9:41 AM rrialq [via Asciidoctor :: Discussion] <
[hidden email]> wrote:

> I've just created the mydoctor-maven-plugin, for hosting the code project.
>
> In https://github.com/mydoctor-maven-plugin/mydoctor-maven-plugin you
> find the code of this new plugin and the documentation for using it in your
> projects.
>
> It is in an early stage, but you can use it, fork it, make pull requests
> and suggest new funcionalities or send issues.
>
> ------------------------------
> If you reply to this email, your message will be added to the discussion
> below:
>
> http://discuss.asciidoctor.org/About-Asciidoctor-Maven-integration-A-custom-lifecycle-tp7063p7076.html
> To start a new topic under Asciidoctor :: Discussion, email
> [hidden email]
> To unsubscribe from Asciidoctor :: Discussion, click here
> <http://discuss.asciidoctor.org/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=1&code=ZGFuLmouYWxsZW5AZ21haWwuY29tfDF8MTY5MzI5MDU4>
> .
> NAML
> <http://discuss.asciidoctor.org/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>


--
Dan Allen | @mojavelinux | https://twitter.com/mojavelinux