Asciidoctor :: Discussion

Re: Committing translation update

Posted by mojavelinux on Aug 01, 2019; 6:35pm
URL: https://discuss.asciidoctor.org/Committing-translation-update-tp7032p7034.html

Alexander is spot on.

@eugeneloza, welcome! When it comes to translations, you don't need to worry about tests (at least not right now). Obviously, if existing tests fail, that would be a problem. But there are no new tests needed. Just focus on getting the words right in the translation file and submit the PR. I may ask for someone to review if the changes are substantial, but most of the time I trust that the community will speak up if there is disagreement.

Best,

-Dan

On Thu, Aug 1, 2019 at 9:04 AM ahus1 [via Asciidoctor :: Discussion] <[hidden email]> wrote:

I've previously contributed an update for the German translation, and this response reflects on the experiences I had as a contributor. Dan will have the final decision on merging AFAIK.
I see that an Ukrainian translation existed before, and you are updating it.
TL;DR: go ahead and create a PR.
The longer version:

create a fork (you've already done that)
create a branch (good practice to not create a PR from the master)
create a pull request with a helpful description
the automatic continuous integration (travis & appveyor) will run all tests
if a test fails due to a translation change, push some more change; maybe cleanup git history first and use force-push
if all test succeed, wait for the PR to be merged
Cheers, Alexander

If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/Committing-translation-update-tp7032p7033.html

To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML

Dan Allen | @mojavelinux | https://twitter.com/mojavelinux