Login  Register

Re: Committing translation update

Posted by Alexander Schwartz on Aug 01, 2019; 3:04pm
URL: https://discuss.asciidoctor.org/Committing-translation-update-tp7032p7033.html

I've previously contributed an update for the German translation, and this response reflects on the experiences I had as a contributor. Dan will have the final decision on merging AFAIK.

I see that an Ukrainian translation existed before, and you are updating it.

TL;DR: go ahead and create a PR.

The longer version:

  1. create a fork (you've already done that)
  2. create a branch (good practice to not create a PR from the master)
  3. create a pull request with a helpful description
  4. the automatic continuous integration (travis & appveyor) will run all tests
  5. if a test fails due to a translation change, push some more change; maybe cleanup git history first and use force-push
  6. if all test succeed, wait for the PR to be merged
Cheers, Alexander
Alexander Schwartz (alexander.schwartz@gmx.net)
https://www.ahus1.de