Re: Including Vimeo videos in a document

Posted by asotobu on
URL: https://discuss.asciidoctor.org/Including-Vimeo-videos-in-a-document-tp492p511.html

Hi Xavier
It is not necessary to modify html5 by default if custom template does not provide an element, the html5 is used. So if you create a custom template with only vídeo block it should work. Of course if Dan thinks that this feature should be implemented in html5 template go ahead there, but you can implement a new template as well

El divendres 23 d’agost de 2013, xcoulon [via Asciidoctor :: Discussion] ha escrit:
Dan,

I'm pretty sure that providing custom output for videos hosted on external services such as Vimeo and Youtube is a common need for users you want to include videos in their article (I'm thinking about blog posts or project sites in particular).

So, I'm planning to open an issue and I also started working on providing you with a PR for that.
Now, I'm a bit confused with the slim template you showed as an example, because I thought the changes would need to be in backends/html5.rb

Can you confirm me where the changes need to be done ? Then I'll submit the PR ;-)

Thanks !

Best regards,
Xavier


If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/Including-Vimeo-videos-in-a-document-tp492p508.html
To unsubscribe from Including Vimeo videos in a document, click here.
NAML


--
Enviat amb Gmail Mobile