Login  Register

Re: [dev] Reorganization of the AsciidoctorJ AST data structures

Posted by Robert.Panzer on Apr 16, 2015; 9:12am
URL: https://discuss.asciidoctor.org/dev-Reorganization-of-the-AsciidoctorJ-AST-data-structures-tp2991p2993.html

Hi Dominik,

Thank you for your feedback.
In particular AbstractBlock was the one that Dan was not really comfortable with.
But it's actually taken from the class names in Ruby :).

What's actuall missing in my first mail is the hierarchy of the interfaces.
It's currently

AbstractNode
  +- AbstractBlock
  |   +- Block
  |   +- Section
  |   +- DocumentRuby
  |   +- ListNode
  |   +- ListItem
  +- Inline

So the current motivation for `Abstract` was that these interfaces are ony implemented by abstract classes.
After renaming AbstractNode to Node, BlockNode would be a good match.
This would result in this hierarchy of interfaces:

Node
  +- BlockNode
  |   +- Block
  |   +- Section
  |   +- Document
  |   +- List
  |   +- ListItem
  +- Inline

What do you think?

Best regards
Robert