Source line highlighting stopped working in asciidoctor-pdf

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Source line highlighting stopped working in asciidoctor-pdf

wimalopaan
The following test stopped working in asciidoctor-pdf, in asciidoctor it is  still working.

= Test
:lang: de
:source-highlighter: pygments
:pygments-css: class
:source-linenums-option:

== Test

[source,cpp,highlight=3]
----
#include <iostream>
int main() {
std::cout << "Hallo!!!\n";
}
----

~/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/bin/asciidoctor-pdf --trace -o test00_r.pdf test00.adoc
Traceback (most recent call last):
28: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/bin/asciidoctor-pdf:27:in `<main>'
27: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/cli/invoker.rb:113:in `invoke!'
26: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/cli/invoker.rb:113:in `each'
25: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/cli/invoker.rb:130:in `block in invoke!'
24: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/convert.rb:189:in `convert_file'
23: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/convert.rb:189:in `open'
22: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/convert.rb:189:in `block in convert_file'
21: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/convert.rb:117:in `convert'
20: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/document.rb:936:in `convert'
19: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:138:in `convert'
18: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:214:in `convert_document'
17: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:596:in `indent_section'
16: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:267:in `block in convert_document'
15: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:155:in `traverse'
14: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/document.rb:1005:in `content'
13: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `content'
12: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `map'
11: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `block in content'
10: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:75:in `convert'
9: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:138:in `convert'
8: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:586:in `convert_section'
7: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:155:in `traverse'
6: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `content'
5: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `map'
4: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `block in content'
3: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:75:in `convert'
2: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:138:in `convert'
1: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:1707:in `convert_listing_or_literal'
/usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/substitutors.rb:978:in `resolve_lines_to_highlight': wrong number of arguments (given1, expected 2..3) (ArgumentError)
Reply | Threaded
Open this post in threaded view
|

Re: Source line highlighting stopped working in asciidoctor-pdf

mojavelinux
Administrator
It's more accurate to say that Asciidoctor 2.0.12 is not compatible with Asciidoctor PDF 1.5.3 when using Pygments. There was an internal change in Asciidoctor that broke Asciidoctor PDF 1.5.3. I already have a fix for it in the v1.5.x branch. See https://github.com/asciidoctor/asciidoctor-pdf/blob/v1.5.x/CHANGELOG.adoc#unreleased I just need to release 1.5.4 now. I'll try to get to that later this week or next.

Best Regards,

-Dan



On Tue, Dec 8, 2020 at 12:15 AM wimalopaan [via Asciidoctor :: Discussion] <[hidden email]> wrote:
The following test stopped working in asciidoctor-pdf, in asciidoctor it is  still working.

= Test
:lang: de
:source-highlighter: pygments
:pygments-css: class
:source-linenums-option:

== Test

[source,cpp,highlight=3]
----
#include <iostream>
int main() {
std::cout << "Hallo!!!\n";
}
----

~/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/bin/asciidoctor-pdf --trace -o test00_r.pdf test00.adoc
Traceback (most recent call last):
28: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/bin/asciidoctor-pdf:27:in `<main>'
27: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/cli/invoker.rb:113:in `invoke!'
26: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/cli/invoker.rb:113:in `each'
25: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/cli/invoker.rb:130:in `block in invoke!'
24: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/convert.rb:189:in `convert_file'
23: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/convert.rb:189:in `open'
22: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/convert.rb:189:in `block in convert_file'
21: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/convert.rb:117:in `convert'
20: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/document.rb:936:in `convert'
19: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:138:in `convert'
18: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:214:in `convert_document'
17: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:596:in `indent_section'
16: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:267:in `block in convert_document'
15: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:155:in `traverse'
14: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/document.rb:1005:in `content'
13: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `content'
12: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `map'
11: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `block in content'
10: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:75:in `convert'
9: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:138:in `convert'
8: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:586:in `convert_section'
7: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:155:in `traverse'
6: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `content'
5: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `map'
4: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:84:in `block in content'
3: from /usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/abstract_block.rb:75:in `convert'
2: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:138:in `convert'
1: from /home/lmeier/.gem/ruby/2.7.0/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb:1707:in `convert_listing_or_literal'
/usr/lib/ruby/gems/2.7.0/gems/asciidoctor-2.0.12/lib/asciidoctor/substitutors.rb:978:in `resolve_lines_to_highlight': wrong number of arguments (given1, expected 2..3) (ArgumentError)



If you reply to this email, your message will be added to the discussion below:
https://discuss.asciidoctor.org/Source-line-highlighting-stopped-working-in-asciidoctor-pdf-tp8392.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML


--
Dan Allen (he, him, his) | @mojavelinux | https://twitter.com/mojavelinux
Reply | Threaded
Open this post in threaded view
|

Re: Source line highlighting stopped working in asciidoctor-pdf

wimalopaan
Hi Dan,

is there hope to get this fixed?

Thx,
 Wilhelm
Reply | Threaded
Open this post in threaded view
|

Re: Source line highlighting stopped working in asciidoctor-pdf

mojavelinux
Administrator
I will try to get a release out this weekend. I have been exceptionally busy trying to get the new docs.asciidoctor.org site live.

-Dan

On Thu, Dec 17, 2020 at 12:57 AM wimalopaan [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Hi Dan,

is there hope to get this fixed?

Thx,
 Wilhelm


If you reply to this email, your message will be added to the discussion below:
https://discuss.asciidoctor.org/Source-line-highlighting-stopped-working-in-asciidoctor-pdf-tp8392p8395.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML


--
Dan Allen (he, him, his) | @mojavelinux | https://twitter.com/mojavelinux
Reply | Threaded
Open this post in threaded view
|

Re: Source line highlighting stopped working in asciidoctor-pdf

wimalopaan
Filed issue #3890
Reply | Threaded
Open this post in threaded view
|

Re: Source line highlighting stopped working in asciidoctor-pdf

mojavelinux
Administrator
As I mentioned, this has already been fixed. I just haven't had a chance yet to make the 1.5.4 release. You'll just need to be patient ;)


Best Regards,

-Dan

On Wed, Dec 23, 2020 at 11:35 PM wimalopaan [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Filed issue #3890


If you reply to this email, your message will be added to the discussion below:
https://discuss.asciidoctor.org/Source-line-highlighting-stopped-working-in-asciidoctor-pdf-tp8392p8426.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML


--
Dan Allen (he, him, his) | @mojavelinux | https://twitter.com/mojavelinux
Reply | Threaded
Open this post in threaded view
|

Re: Source line highlighting stopped working in asciidoctor-pdf

wimalopaan
Can give a forcast fixing this bug? I need a workaround ...
Reply | Threaded
Open this post in threaded view
|

Re: Source line highlighting stopped working in asciidoctor-pdf

mojavelinux
Administrator
The workaround is to use Asciidoctor 2.0.10. No one is forcing you to use the version that previously worked.

I can't give an estimate because it just depends on when I'm available. And since it's been the holidays, I haven't been available.

-Dan

On Wed, Jan 6, 2021, 23:43 wimalopaan [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Can give a forcast fixing this bug? I need a workaround ...


If you reply to this email, your message will be added to the discussion below:
https://discuss.asciidoctor.org/Source-line-highlighting-stopped-working-in-asciidoctor-pdf-tp8392p8432.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML
Reply | Threaded
Open this post in threaded view
|

Re: Source line highlighting stopped working in asciidoctor-pdf

mojavelinux
Administrator
Things calmed down a bit and I'm happy to report that Asciidoctor PDF 1.5.4 is now available.


Best Regards,

-Dan

On Thu, Jan 7, 2021 at 12:30 AM mojavelinux [via Asciidoctor :: Discussion] <[hidden email]> wrote:
The workaround is to use Asciidoctor 2.0.10. No one is forcing you to use the version that previously worked.

I can't give an estimate because it just depends on when I'm available. And since it's been the holidays, I haven't been available.

-Dan

On Wed, Jan 6, 2021, 23:43 wimalopaan [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Can give a forcast fixing this bug? I need a workaround ...


If you reply to this email, your message will be added to the discussion below:
https://discuss.asciidoctor.org/Source-line-highlighting-stopped-working-in-asciidoctor-pdf-tp8392p8432.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



If you reply to this email, your message will be added to the discussion below:
https://discuss.asciidoctor.org/Source-line-highlighting-stopped-working-in-asciidoctor-pdf-tp8392p8433.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML


--
Dan Allen (he, him, his) | @mojavelinux | https://twitter.com/mojavelinux