A bug on asciidoctor 0.1.4 in UI Macros?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

A bug on asciidoctor 0.1.4 in UI Macros?

asotobu
Hi I have the next document:

= UI Macros
:experimental:
:icons: font

== Keyboard

When users push kbd:[F5] webpage should be refreshed.

When users push kbd:[Ctrl+T] a new tab should be opened.

== Menus

When user navigate to menu:File[Save] page should be saved.

== Buttons

When user select btn:[Ok] transaction should be committed.


Keyboard and Menus are rendered correctly but not the buttons. You can see also an example on Asciidoctor manual:
http://asciidoctor.org/docs/user-manual/#ui-buttons where button are rendered in bold but not with the blue square it was rendered in previous versions.

Maybe I am missing some attribute but I think it should work.
Reply | Threaded
Open this post in threaded view
|

Re: A bug on asciidoctor 0.1.4 in UI Macros?

LightGuardjp
Administrator
This may be a change in the stylesheet. The backend shouldn't change this and it's more than likely a cosmetic issue that can be easily fixed via some css. Do you still have a rendering of previous versions to check the difference?


On Thu, Sep 12, 2013 at 6:50 AM, asotobu [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Hi I have the next document:

= UI Macros
:experimental:
:icons: font

== Keyboard

When users push kbd:[F5] webpage should be refreshed.

When users push kbd:[Ctrl+T] a new tab should be opened.

== Menus

When user navigate to menu:File[Save] page should be saved.

== Buttons

When user select btn:[Ok] transaction should be committed.


Keyboard and Menus are rendered correctly but not the buttons. You can see also an example on Asciidoctor manual:
http://asciidoctor.org/docs/user-manual/#ui-buttons where button are rendered in bold but not with the blue square it was rendered in previous versions.

Maybe I am missing some attribute but I think it should work.



If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/A-bug-on-asciidoctor-0-1-4-in-UI-Macros-tp576.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



--
Reply | Threaded
Open this post in threaded view
|

Re: A bug on asciidoctor 0.1.4 in UI Macros?

mojavelinux
Administrator
Correct. I took out the button styling because I believe it is misleading. You aren't defining a button in the documentation, but rather referring to a button in the UI (for which the look and feel varies widely). We can style the keyboard as a keyboard button because that's a recognizable object in the real world and pretty much looks the same everywhere.

As Jason mentioned, it's possible to customize the look and feel using styles in a docinfo file or custom stylesheet. Though, if there is a better style choice than simply bold text for the default stylesheet, we could certainly consider making that change.

Now that I think about it, the following CSS would probably fit well here:

```css
b.button:before {
  content: "[ ";
}

b.button:after {
  content: " ]";
}
```

Then, it would appear as: Click on the [ OK ] button to continue.

wdyt?

-Dan


On Thu, Sep 12, 2013 at 9:00 AM, LightGuardjp [via Asciidoctor :: Discussion] <[hidden email]> wrote:
This may be a change in the stylesheet. The backend shouldn't change this and it's more than likely a cosmetic issue that can be easily fixed via some css. Do you still have a rendering of previous versions to check the difference?


On Thu, Sep 12, 2013 at 6:50 AM, asotobu [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Hi I have the next document:

= UI Macros
:experimental:
:icons: font

== Keyboard

When users push kbd:[F5] webpage should be refreshed.

When users push kbd:[Ctrl+T] a new tab should be opened.

== Menus

When user navigate to menu:File[Save] page should be saved.

== Buttons

When user select btn:[Ok] transaction should be committed.


Keyboard and Menus are rendered correctly but not the buttons. You can see also an example on Asciidoctor manual:
http://asciidoctor.org/docs/user-manual/#ui-buttons where button are rendered in bold but not with the blue square it was rendered in previous versions.

Maybe I am missing some attribute but I think it should work.



If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/A-bug-on-asciidoctor-0-1-4-in-UI-Macros-tp576.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



--



If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/A-bug-on-asciidoctor-0-1-4-in-UI-Macros-tp576p581.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



--
Reply | Threaded
Open this post in threaded view
|

Re: A bug on asciidoctor 0.1.4 in UI Macros?

mojavelinux
Administrator
In reply to this post by LightGuardjp
I should say, "file an issue if you like the idea" :)

-Dan


On Fri, Sep 13, 2013 at 8:10 PM, Dan Allen <[hidden email]> wrote:
Correct. I took out the button styling because I believe it is misleading. You aren't defining a button in the documentation, but rather referring to a button in the UI (for which the look and feel varies widely). We can style the keyboard as a keyboard button because that's a recognizable object in the real world and pretty much looks the same everywhere.

As Jason mentioned, it's possible to customize the look and feel using styles in a docinfo file or custom stylesheet. Though, if there is a better style choice than simply bold text for the default stylesheet, we could certainly consider making that change.

Now that I think about it, the following CSS would probably fit well here:

```css
b.button:before {
  content: "[ ";
}

b.button:after {
  content: " ]";
}
```

Then, it would appear as: Click on the [ OK ] button to continue.

wdyt?

-Dan


On Thu, Sep 12, 2013 at 9:00 AM, LightGuardjp [via Asciidoctor :: Discussion] <[hidden email]> wrote:
This may be a change in the stylesheet. The backend shouldn't change this and it's more than likely a cosmetic issue that can be easily fixed via some css. Do you still have a rendering of previous versions to check the difference?


On Thu, Sep 12, 2013 at 6:50 AM, asotobu [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Hi I have the next document:

= UI Macros
:experimental:
:icons: font

== Keyboard

When users push kbd:[F5] webpage should be refreshed.

When users push kbd:[Ctrl+T] a new tab should be opened.

== Menus

When user navigate to menu:File[Save] page should be saved.

== Buttons

When user select btn:[Ok] transaction should be committed.


Keyboard and Menus are rendered correctly but not the buttons. You can see also an example on Asciidoctor manual:
http://asciidoctor.org/docs/user-manual/#ui-buttons where button are rendered in bold but not with the blue square it was rendered in previous versions.

Maybe I am missing some attribute but I think it should work.



If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/A-bug-on-asciidoctor-0-1-4-in-UI-Macros-tp576.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



--



If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/A-bug-on-asciidoctor-0-1-4-in-UI-Macros-tp576p581.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



--



--
Reply | Threaded
Open this post in threaded view
|

Re: A bug on asciidoctor 0.1.4 in UI Macros?

asotobu
Yes I think that at least the [ , ] would be necessary with the bold style because it will give a different look not as simple text.