v1.5.6.1 caption label (Figure) and number is missing via asciidoctor-diagram

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

v1.5.6.1 caption label (Figure) and number is missing via asciidoctor-diagram

azarasi
Hi,
with v1.5.6.1, when I generate the diagram-image via asciidoctor-diagram(v1.5.5),
caption label(Figure) and automatic number is missing.

There is no problem with just an image.
And there is no problem with v1.5.5.

What is going on?

 --azarasi
Reply | Threaded
Open this post in threaded view
|

Re: v1.5.6.1 caption label (Figure) and number is missing via asciidoctor-diagram

Jeremie Bresson
I did a quick test with the asciidoctor-diagram-example [1]

[1] https://github.com/asciidoctor/asciidoctor-maven-examples/tree/master/asciidoctor-diagram-example

Of course I needed to add some caption everywhere, like here:
[graphviz, dot-example, svg]
.this is a test
----
digraph g {
    a -> b
    b -> c
    c -> d
    d -> a
}
----

I have also set ":figure-caption:" to a value.

I can confirm that the output is not the same with:
        <asciidoctorj.version>1.5.5</asciidoctorj.version>
        <asciidoctorj.diagram.version>1.5.4</asciidoctorj.diagram.version>
=> OK

and with:
        <asciidoctorj.version>1.5.6</asciidoctorj.version>
        <asciidoctorj.diagram.version>1.5.4.1</asciidoctorj.diagram.version>
=> NOK: Figure caption is missing
Reply | Threaded
Open this post in threaded view
|

Re: v1.5.6.1 caption label (Figure) and number is missing via asciidoctor-diagram

mojavelinux
Administrator
This is a known regression in Asciidoctor Diagram caused by a change to core. It's now being addressed.


Since the release of Asciidoctor 1.5.6.1, we've configured the Asciidoctor Diagram test suite to run against upstream core. That should allow us to avoid these types of regressions in the future (before a version of core gets released).

-Dan

On Tue, Sep 12, 2017 at 12:55 PM, Jeremie Bresson [via Asciidoctor :: Discussion] <[hidden email]> wrote:
I did a quick test with the asciidoctor-diagram-example [1]

[1] https://github.com/asciidoctor/asciidoctor-maven-examples/tree/master/asciidoctor-diagram-example

Of course I needed to add some caption everywhere, like here:
[graphviz, dot-example, svg]
.this is a test
----
digraph g {
    a -> b
    b -> c
    c -> d
    d -> a
}
----

I have also set ":figure-caption:" to a value.

I can confirm that the output is not the same with:
        <asciidoctorj.version>1.5.5</asciidoctorj.version>
        <asciidoctorj.diagram.version>1.5.4</asciidoctorj.diagram.version>
=> OK

and with:
        <asciidoctorj.version>1.5.6</asciidoctorj.version>
        <asciidoctorj.diagram.version>1.5.4.1</asciidoctorj.diagram.version>
=> NOK: Figure caption is missing


If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/v1-5-6-1-caption-label-Figure-and-number-is-missing-via-asciidoctor-diagram-tp5871p5897.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



--
Dan Allen | @mojavelinux | https://twitter.com/mojavelinux
Reply | Threaded
Open this post in threaded view
|

Re: v1.5.6.1 caption label (Figure) and number is missing via asciidoctor-diagram

azarasi
My problem was solved with this.
Everyone, thank you for your correspondence.

--azarasi