[dev] New name for class org.asciidoctor.ast.Inline

Hi,

as announced we want to rename the class names for the AST data structures.
While I think we have found a common understanding for most class names there was quite some discussion around the new name for org.asciidoctor.ast.Inline.
There is already an open PR: https://github.com/asciidoctor/asciidoctorj/pull/371

I've prepared a TypeForm to collect the opinion of the community: https://robertpanzer.typeform.com/to/TSlw0E

As it seems that all votes have been collected I wanted to post the current results:

11 out of 11 people answered this question
org.asciidoctor.ast.Inline (Keep the existing name) 5 / 45%
org.asciidoctor.ast.PhraseNode 3 / 27%
org.asciidoctor.ast.PhrasingNode 2 / 18%
Other 1 / 9%

So at the moment the community seems to prefer to stick with the current name org.asciidoctor.ast.Inline.

Best regards
Robert
 

I voted for Inline for the same reasons that Sean explained  in  http://discuss.asciidoctor.org/dev-Renaming-of-the-AST-classes-Concerns-all-extension-and-converter-writers-td3641.html.

I can see that PhrasingNode is a more correct way and the W3C definition provided by Dan makes things clear. But I think that most of the users will find Inline a more natural name.

Thanks Robert for the effort,

Interesting results. Even after a few weeks and working on some other Asciidoctor extensions, "Inline" still seems like the better name.

Thanks for the update Robert!

Just wanted to give the current results:

6 votes for PhraseNode
5 votes for Inline
2 votes for PhrasingNode
1 vote for Phrase

I think we should keep the voting open until end of September and then come to a conclusion.

Best regards
Robert