Re: AsciidoctorJ Screnshut Extension

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: AsciidoctorJ Screnshut Extension

mojavelinux
Administrator
Very interesting!

I'd be happy to add this to the extension list page at http://asciidoctor.org/docs/extensions/. Just send a PR.

I have a few small suggestions.

1. The think that takeScreenshot would work better as a block macro (and perhaps shorten it to screenshot)

.Google home page
[name=google]
screenshot::http://google.com[]

That brings it more inline with the syntax in Asciidoctor Diagram.

2. Instead of "driveBrowser", perhaps name the block "navigate" or "browse"

[browse]
$("input", name: "q").value("asciidoctor")
waitFor(5){true}

3. The examples repository is misspelled (it's missing the "c" in screenshot)

Exciting stuff!

Cheers,

-Dan

On Wed, Feb 24, 2016 at 4:50 PM, sclassen [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Hi

I created a standalone screenshot extension based on the work of François-Xavier Thoorens. He discussed his work on this list: screenshot-plugin-for-asciidoctor

As a first version I did not incorporate most of the suggested changes into the code.
If you still find it useful I would donate this to the asciidoctor community and we can create issues on github for the suggested improvements.

Cheers
Stephan

asciidoctorj-screenshot
asciidoctorj-sreenshot-example


If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/AsciidoctorJ-Screnshut-Extension-tp4400.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



--
Dan Allen | @mojavelinux | http://google.com/profiles/dan.j.allen