Internal Cross References text not resolved anymore ?

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Internal Cross References text not resolved anymore ?

phgiraud
Hi,
Thanks for Asciidoctor, we really love the features it provides !
But we have an issue with latest version 2.0.10 that we did not have in 1.5.8.

We have this section:

==== Price Variation Threshold logic

And a reference to it:

See <<_price_variation_threshold_logic>> below for more details.

In 1.5.8, the generated HTML was:

See Price Variation Threshold logic below for more details.

Now we get:

See [_price_variation_threshold_logic] below for more details.

(in both versions, the link works fine).

Could you please help us ?

thanks
Regards
PH GIRAUD
smartTrade Technologies

Reply | Threaded
Open this post in threaded view
|

Re: Internal Cross References text not resolved anymore ?

mojavelinux
Administrator
Paul-Henri,

I'm unable to reproduce this issue. Are you sure you haven't modified idprefix or idseparator? Can you provide more context, such as a full example and how you are running Asciidoctor? I expect your example to work under normal circumstances.

Best,

-Dan

On Mon, Jul 8, 2019 at 7:48 AM phgiraud [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Hi,
Thanks for Asciidoctor, we really love the features it provides !
But we have an issue with latest version 2.0.10 that we did not have in 1.5.8.

We have this section:

==== Price Variation Threshold logic

And a reference to it:

See <<_price_variation_threshold_logic>> below for more details.

In 1.5.8, the generated HTML was:

See Price Variation Threshold logic below for more details.

Now we get:

See [_price_variation_threshold_logic] below for more details.

(in both versions, the link works fine).

Could you please help us ?

thanks
Regards
PH GIRAUD
smartTrade Technologies




If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/Internal-Cross-References-text-not-resolved-anymore-tp6979.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML


--
Dan Allen | @mojavelinux | https://twitter.com/mojavelinux
Reply | Threaded
Open this post in threaded view
|

Re: Internal Cross References text not resolved anymore ?

phgiraud
Hi Dan,
Thanks for your very quick answer.

We have this comment line:

asciidoctor -T $cwd/$styles_root_html/html5 $full_adoc_dir/$source_doc --doctype book --destination-dir $full_html_out_dir --out-file $source_doc_no_ext.html -a stylesheet=styles.css -a stylesdir=$cwd/$styles_root_html/css -a year="$year" -a generation_date_time="$generation_date_time" -a generation_date_time_meta="$generation_date_time_meta" -a revnumber="$revnumber" -a email="$email" $toc_prop -a toclevels="$toc_level" -a chapter-label="" -a sectnums="" -a guides_url="$guides_url" -a icons="font" -a source-highlighter="highlightjs" -a pdfs_url="$pdfs_url" -a author="$author" -a docinfo="shared" -a docinfodir="$cwd/$styles_root_html/html5" -a gitlab_guide_url="$gitlab_guide_url" -a season_index_url="$season_index_url" -a main_index_url="$main_index_url" -a api_pdfs_url="$api_pdfs_url"

And I think I have localized the issue, because when I remove:

-T $cwd/$styles_root_html/html5

The texts for the links are now correct.
I'm now trying to find out what's wrong in our styling files.

Reply | Threaded
Open this post in threaded view
|

Re: Internal Cross References text not resolved anymore ?

mojavelinux
Administrator
Indeed, it appears that your template for inline_anchor is out of date. I recommend consulting the built-in HTML5 converter for the most current logic.


Fortunately, it's not too much logic to review.

Best,

-Dan

On Tue, Jul 9, 2019 at 12:36 AM phgiraud [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Hi Dan,
Thanks for your very quick answer.

We have this comment line:

asciidoctor -T $cwd/$styles_root_html/html5 $full_adoc_dir/$source_doc --doctype book --destination-dir $full_html_out_dir --out-file $source_doc_no_ext.html -a stylesheet=styles.css -a stylesdir=$cwd/$styles_root_html/css -a year="$year" -a generation_date_time="$generation_date_time" -a generation_date_time_meta="$generation_date_time_meta" -a revnumber="$revnumber" -a email="$email" $toc_prop -a toclevels="$toc_level" -a chapter-label="" -a sectnums="" -a guides_url="$guides_url" -a icons="font" -a source-highlighter="highlightjs" -a pdfs_url="$pdfs_url" -a author="$author" -a docinfo="shared" -a docinfodir="$cwd/$styles_root_html/html5" -a gitlab_guide_url="$gitlab_guide_url" -a season_index_url="$season_index_url" -a main_index_url="$main_index_url" -a api_pdfs_url="$api_pdfs_url"

And I think I have localized the issue, because when I remove:

-T $cwd/$styles_root_html/html5

The texts for the links are now correct.
I'm now trying to find out what's wrong in our styling files.




If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/Internal-Cross-References-text-not-resolved-anymore-tp6979p6981.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML


--
Dan Allen | @mojavelinux | https://twitter.com/mojavelinux
Reply | Threaded
Open this post in threaded view
|

Re: Internal Cross References text not resolved anymore ?

phgiraud
Thank you very much, indeed, my "slim" files were out of date.
I'm going to read the most current logic carefully.

best,
Paul
Reply | Threaded
Open this post in threaded view
|

Re: Internal Cross References text not resolved anymore ?

phgiraud
Hi again,
Actually I was using this:

https://github.com/asciidoctor/asciidoctor-backends/tree/master/slim/html5

Seems that the files here are out of date. I have only kept the one I modified and now all is fine.
Reply | Threaded
Open this post in threaded view
|

Re: Internal Cross References text not resolved anymore ?

mojavelinux
Administrator
Those templates are meant strictly as a starting point. They are not actively maintained and should not be used for "production" code. It's just too much work for me to maintain them. If the community wants to help keep them up to date, I welcome the help. My only focus is on the built-in converters provided by Asciidoctor itself.

Best,

-Dan

On Tue, Jul 9, 2019 at 1:06 AM phgiraud [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Hi again,
Actually I was using this:

https://github.com/asciidoctor/asciidoctor-backends/tree/master/slim/html5

Seems that the files here are out of date. I have only kept the one I modified and now all is fine.


If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/Internal-Cross-References-text-not-resolved-anymore-tp6979p6984.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML


--
Dan Allen | @mojavelinux | https://twitter.com/mojavelinux