1.5.3.2 release & Maven plugin

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

1.5.3.2 release & Maven plugin

Jeremie Bresson
I just discovered that there was a 1.5.3.2 release last month… This is great!

What is the strategy for the asciidoctor-maven-plugin?

Of course the 1.5.2.1 version of the "asciidoctor-maven-plugin" is compatible with the new version of asciidoctorj. In your pom you just need to indicate a new version of the Asciidoctorj:
                    <dependency>
                        <groupId>org.asciidoctor</groupId>
                        <artifactId>asciidoctorj</artifactId>
                        <version>1.5.3.2</version>
                    </dependency>
See the corresponding pom section in the "asciidoc-to-html-example".

In my opinion not having an up-to-date maven plugin is not user-friendly. On the other hand, doing an "asciidcotor-maven-plugin" release just to update the asciidoctorj version might also be too much work.

What are the opinions on this topic?

The JRuby dependency (it can also be overridden in the POM) is a related topic.
I have updated to the latest 9.0.4.0
Should the "asciidcotor-maven-plugin" also set its default to this JRuby version?

--------------------------------------------------------

Related to "asciidcotor-maven-plugin" there are similar questions for the "asciidoctor-maven-examples" project:
What is the strategy here?

In my opinion, we should update to the latest version of the dependencies:
* AsciidoctorJ => 1.5.3.2
* AsciidoctorJ PDF => 1.5.0-alpha.10.1
* AsciidoctorJ Diagram => 1.3.1 (if possible)
* JRuby => 9.0.4.0

My reasons:
a/ It is a good test.
b/ It is a good start for newcomers (that the public who will have a look at the example).

I can prepare a pull request for that.

Related discussion:
* Projects versioning strategy.

Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

mojavelinux
Administrator

What is the strategy for the asciidoctor-maven-plugin?

We want to get an update out asap. There are a few issues I'd really like to see addressed as part of this release.


I'd be glad to help get those resolved.
 

In my opinion not having an up-to-date maven plugin is not user-friendly. On the other hand, doing an "asciidcotor-maven-plugin" release just to update the asciidoctorj version might also be too much work.

In the past, we've always done one Asciidoctor Maven plugin release per AsciidoctorJ release. I agree I think its important for usability, as you point out.
 


The JRuby dependency (it can also be overridden in the POM) is a related topic.
I have updated to the latest 9.0.4.0
Should the "asciidcotor-maven-plugin" also set its default to this JRuby version?

I've gone back and forth on this one, and I'm just not sure what the right answer is. On the one hand, we are recommending using JRuby 9000. While JRuby 1.7 is still being updated, users are being encouraged to move to JRuby 9000. On the other hand, 1.5.3 is only a patch release number, so it seems wrong to be switching to the next major version of JRuby. Then again, Asciidoctor 1.5.3 was really more of a major release. You can see why I'm torn.

 

--------------------------------------------------------

Related to "asciidcotor-maven-plugin" there are similar questions for the "asciidoctor-maven-examples" project:
What is the strategy here?

The examples project should definitely use all the latest and greatest as these are the archetypes of what we want people to use. Some I'm in favor of using JRuby 9000 here (and all the latest of the Asciidoctor components).
 

In my opinion, we should update to the latest version of the dependencies:
* AsciidoctorJ => 1.5.3.2
* AsciidoctorJ PDF => 1.5.0-alpha.10.1
* AsciidoctorJ Diagram => 1.3.1 (if possible)
* JRuby => 9.0.4.0

+1

Thanks!

-Dan

--
Dan Allen | @mojavelinux | http://google.com/profiles/dan.j.allen
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

mojavelinux
Administrator
In reply to this post by Jeremie Bresson
This weekend I figured out how to pass configuration from the pom.xml to the site parser module. Here's an example of how that configuration will look:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-site-plugin</artifactId>
    <version>3.3</version> <!-- 3.4 also works -->
    <configuration>
        <asciidoc>
            <templateDir>src/site/asciidoc/templates</templateDir>
            <requires>
                <require>asciidoctor-diagram</require>
            </requires>
            <attributes>
                <source-highlighter>coderay</source-highlighter>
                <coderay-css>style</coderay-css>
            </attributes>
        </asciidoc>
        <moduleExcludes>
            <asciidoc>**/_*.adoc</asciidoc>
        </moduleExcludes>
    </configuration>
    <dependencies>
        <dependency>
            <groupId>org.asciidoctor</groupId>
            <artifactId>asciidoctor-maven-plugin</artifactId>
            <version>1.5.3</version>
        </dependency>
    </dependencies>
</plugin>

Once https://github.com/asciidoctor/asciidoctor-maven-plugin/pull/182 is merged, all that is left is to upgrade AsciidoctorJ (and possibly JRuby) and we'll be ready for the 1.5.3 release.

Cheers,

-Dan

--
Dan Allen | @mojavelinux | http://google.com/profiles/dan.j.allen
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

Robert.Panzer
Hi!

Just one comment from my side:

I'd really prefer to not use JRuby 9.0.4.0.
It doesn't play well with asciidoctorj-diagram on Windows when rendering sth else than ditaa diagrams (https://github.com/jruby/jruby/issues/3473)

I can retest if it runs with 9.0.3.0 and report here later.

JRuby & Windows are not really friends;-)

- Robert
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

Robert.Panzer
Just retested the diagram extension on Win7 with different JRuby versions:

On 9.0.4.0 the rendering a graphviz block never terminates: https://github.com/jruby/jruby/issues/3473
On 9.0.3.0 we're hit by this: https://github.com/jruby/jruby/issues/3430 (No TMPDIR available)
With 9.0.2.0 I get some strange NullPointerException from at org.jruby.util.io.OpenFile.rbW32WriteConsole(OpenFile.java:2045) where I have no idea atm.
9.0.1.0 seems to hang as well with asciidoctorj-diagram.

So as long as we see these problems I have no good feeling about switching to JRuby 9000.
Even though one might argue that this only happens on a very exotic OS;-)

- Robert
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

mojavelinux
Administrator

Wow, we can't seem to find a target 😧Thanks for testing!!

In general, I'd say JRuby 9000 looks much better than JRuby 1.7... except for this use case.

The ultimate solution is that JRuby really needs to get their test suite working on Appveyor because this should be covered by their tests.

If there's any information we can give them about why it hangs, let's try to help. We really need JRuby 9000.

-Dan

Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

nawroth
Hi!

I tried different JRuby versions for this project:

(Using gradle, but not the Asciidoctor gradle plugin.)

With 9.0.4.0 the build hangs during PDF generation.
9.0.3.0 worked fine, but was slower than 1.7.23.

/anders

2015-12-16 12:14 GMT+01:00 mojavelinux [via Asciidoctor :: Discussion] <[hidden email]>:

Wow, we can't seem to find a target 😧Thanks for testing!!

In general, I'd say JRuby 9000 looks much better than JRuby 1.7... except for this use case.

The ultimate solution is that JRuby really needs to get their test suite working on Appveyor because this should be covered by their tests.

If there's any information we can give them about why it hangs, let's try to help. We really need JRuby 9000.

-Dan




If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/1-5-3-2-release-Maven-plugin-tp4059p4104.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML

Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

mojavelinux
Administrator

Thanks for testing Anders!

I didn't think to test the speed difference (which is surprising coming from me since normally I'm obsessed with that factor). I'm kind of shocked it's slower.

PDF generation in general is hanging you say? On Windows or another platform?

-Dan

p.s. I finally have my test lab running again (Windows, OSX, Linux) after all my moves, so I can actually do full manual testing again.

Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

nawroth
I didn't try other documents, but with ours it did hang.

I'm on Ubuntu 15.10.
JVM:          1.8.0_66 (Oracle Corporation 25.66-b17)
OS:           Linux 4.2.0-19-lowlatency amd64

/anders

2015-12-16 19:05 GMT+01:00 mojavelinux [via Asciidoctor :: Discussion]
<[hidden email]>:

> Thanks for testing Anders!
>
> I didn't think to test the speed difference (which is surprising coming from
> me since normally I'm obsessed with that factor). I'm kind of shocked it's
> slower.
>
> PDF generation in general is hanging you say? On Windows or another
> platform?
>
> -Dan
>
> p.s. I finally have my test lab running again (Windows, OSX, Linux) after
> all my moves, so I can actually do full manual testing again.
>
>
>
> ________________________________
> If you reply to this email, your message will be added to the discussion
> below:
> http://discuss.asciidoctor.org/1-5-3-2-release-Maven-plugin-tp4059p4106.html
> To start a new topic under Asciidoctor :: Discussion, email
> [hidden email]
> To unsubscribe from Asciidoctor :: Discussion, click here.
> NAML
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

abelsromero
Hi all,

I had to set up a new machine but I have everything ready now.
Is there is nothing else to add I can release first thing in the morning.
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

mojavelinux
Administrator
+1 Go for it!

-Dan

On Sat, Dec 19, 2015 at 4:34 PM, abelsromero [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Hi all,

I had to set up a new machine but I have everything ready now.
Is there is nothing else to add I can release first thing in the morning.


If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/1-5-3-2-release-Maven-plugin-tp4059p4114.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



--
Dan Allen | @mojavelinux | http://google.com/profiles/dan.j.allen
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

abelsromero
All done!
Bintray reports that it was Synced without issues half and hour ago, but still does not appear in Central.
I'll keep checking.
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

abelsromero
Checked :)
Version 1.5.3 published and available.

@Dan, I leave to you the official announcement on twitter.
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

mojavelinux
Administrator
Nice work Abel!

-Dan

On Sun, Dec 20, 2015 at 8:55 AM, abelsromero [via Asciidoctor :: Discussion] <[hidden email]> wrote:
Checked :)
Version 1.5.3 published and available.

@Dan, I leave to you the official announcement on twitter.


If you reply to this email, your message will be added to the discussion below:
http://discuss.asciidoctor.org/1-5-3-2-release-Maven-plugin-tp4059p4120.html
To start a new topic under Asciidoctor :: Discussion, email [hidden email]
To unsubscribe from Asciidoctor :: Discussion, click here.
NAML



--
Dan Allen | @mojavelinux | http://google.com/profiles/dan.j.allen
Reply | Threaded
Open this post in threaded view
|

Re: 1.5.3.2 release & Maven plugin

Jeremie Bresson
In reply to this post by Robert.Panzer
Robert.Panzer wrote
Just retested the diagram extension on Win7 with different JRuby versions:

On 9.0.4.0 the rendering a graphviz block never terminates: https://github.com/jruby/jruby/issues/3473
On 9.0.3.0 we're hit by this: https://github.com/jruby/jruby/issues/3430 (No TMPDIR available)
With 9.0.2.0 I get some strange NullPointerException from at org.jruby.util.io.OpenFile.rbW32WriteConsole(OpenFile.java:2045) where I have no idea atm.
9.0.1.0 seems to hang as well with asciidoctorj-diagram.
I just tested jruby 9.0.5.0. It works for my use case (some dot files in an asciidoct document, maven build, win 7).

Can someone else test it?